Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-1655] Added multiline support for FTP plugin. #43

Merged

Conversation

vikasrathee-cs
Copy link
Contributor

No description provided.

@vikasrathee-cs vikasrathee-cs added the build Trigger Unit Tests label Jul 13, 2023
Copy link
Contributor

@albertshau albertshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this won't work properly with older versions of the format plugins, we should change the lower bound of the parent (

<data.pipeline.parent>system:cdap-data-pipeline[6.8.0-SNAPSHOT,7.0.0-SNAPSHOT)</data.pipeline.parent>
) to be 6.9.2. That way the plugin will only be usable with CDAP versions that have support for it out of the box.

(Also will need to cherry-pick the change in hydrator-plugins repo from develop to the latest release branch).

@vikasrathee-cs
Copy link
Contributor Author

lower

Changes done in pom.xml file, I have changed the lower version for both <data.pipeline.parent> and <data.stream.parent> tags.

Added multiline support
@vikasrathee-cs vikasrathee-cs merged commit ced248c into data-integrations:develop Jul 20, 2023
3 checks passed
@vikasrathee-cs vikasrathee-cs changed the title Added multiline support for FTP plugin. [PLUGIN-1655] Added multiline support for FTP plugin. Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Trigger Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants